-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support subcategories, reorganise Engineering Handbook #408
Conversation
✅ Deploy Preview for meltano-handbook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Right now each subcategory has an index page shown underneath the category in the table of contents. This results in each category title being repeated. Would it be possible for the category item in the table of contents to be clickable, and have the index page, rather than listing the index page beneath it?
If this isn't a relatively simple change, I'd say don't bother with it.
cc @tayloramurphy as I believe this was something you wanted to be able to do. |
I think its possible, but it involves iterating all the matching subcategory items page-urls looking for one ending in Longer-term, I think it'd be better to just move to a more flexible (and more familiar) static site generator, Sphinx. |
@WillDaSilva it turned out to be easy 😅👍 |
There doesn't seem to be a supported way to do subcategories in Jekyll, so I used a workaround using Front Matter
subcategory
values. Bulma (the CSS library we are using) only supports 2 levels of depth inmenu
classes, which limits how much subcategorisation we can ultimately do, but 2 is still way better than 1 😅Did this as I hope
Guilds
will become a subcategory 👍